Fix vehicle heater consuming too much energy #66504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
<Bugfix>
github-actions
bot
added
the
BasicBuildPassed
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: irwiss <[email protected]>
github-actions
bot
removed
the
astyled
SurFlurer
changed the title
github-actions
bot
added
the
astyled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
none
Purpose of change
Fix #66237
Describe the solution
Apply irwiss's suggestion, move emitter handling code to vehicle::idle(), after
on_mapcheck. That's because the emitters must be on map to generate fields. This avoids the hassle of dealing with emitters' battery drain separately.Describe alternatives you've considered
none
Testing
Emitter's power drain returned to normal.
Additional context